From 04eb87493d17961172629f6df452e80f180d39a4 Mon Sep 17 00:00:00 2001
From: Piotr Gawron <piotr.gawron@uni.lu>
Date: Fri, 30 Jun 2017 13:54:31 +0200
Subject: [PATCH] error reporting improved

---
 .../reactome/xml/ReactomeBlackBoxEventParserTest.java     | 8 ++++----
 .../reactome/xml/ReactomeCandidateSetParserTest.java      | 8 ++++----
 .../reactome/xml/ReactomeCatalystActivityParserTest.java  | 8 ++++----
 .../reactome/xml/ReactomeDefinedSetParserTest.java        | 8 ++++----
 .../xml/ReactomeGenomeEncodedEntityParserTest.java        | 8 ++++----
 .../reactome/xml/ReactomeOtherEntityParserTest.java       | 8 ++++----
 .../mapviewer/reactome/xml/ReactomePathwayParserTest.java | 8 ++++----
 7 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeBlackBoxEventParserTest.java b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeBlackBoxEventParserTest.java
index dee4b6235d..188e2ba612 100644
--- a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeBlackBoxEventParserTest.java
+++ b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeBlackBoxEventParserTest.java
@@ -29,7 +29,7 @@ public class ReactomeBlackBoxEventParserTest extends ReactomeTestFunctions {
 	}
 
 	@Test
-	public void testParseObject() {
+	public void testParseObject() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/blackBoxEvent.xml");
 			ReactomeBlackBoxEvent res = parser.parseObject(document.getChildNodes().item(0));
@@ -58,12 +58,12 @@ public class ReactomeBlackBoxEventParserTest extends ReactomeTestFunctions {
 			assertEquals("Caspase-8 processing ", res.getNames().get(0));
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
 	@Test
-	public void testUpdateObjectFromDb() {
+	public void testUpdateObjectFromDb() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/blackBoxEvent.xml");
 			ReactomeBlackBoxEvent res = parser.parseObject(document.getChildNodes().item(0));
@@ -87,7 +87,7 @@ public class ReactomeBlackBoxEventParserTest extends ReactomeTestFunctions {
 
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
diff --git a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeCandidateSetParserTest.java b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeCandidateSetParserTest.java
index 9e19d67273..b2cd3015e8 100644
--- a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeCandidateSetParserTest.java
+++ b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeCandidateSetParserTest.java
@@ -28,7 +28,7 @@ public class ReactomeCandidateSetParserTest extends ReactomeTestFunctions{
 	}
 
 	@Test
-	public void testParseObject() {
+	public void testParseObject() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/candidateSet.xml");
 			ReactomeCandidateSet res = parser.parseObject(document.getChildNodes().item(0));
@@ -49,12 +49,12 @@ public class ReactomeCandidateSetParserTest extends ReactomeTestFunctions{
 			
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
 	@Test
-	public void testUpdateObjectFromDb() {
+	public void testUpdateObjectFromDb() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/candidateSet.xml");
 			ReactomeCandidateSet res = parser.parseObject(document.getChildNodes().item(0));
@@ -72,7 +72,7 @@ public class ReactomeCandidateSetParserTest extends ReactomeTestFunctions{
 			
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
diff --git a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeCatalystActivityParserTest.java b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeCatalystActivityParserTest.java
index 03913bc314..e4d80756f6 100644
--- a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeCatalystActivityParserTest.java
+++ b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeCatalystActivityParserTest.java
@@ -28,7 +28,7 @@ public class ReactomeCatalystActivityParserTest extends ReactomeTestFunctions{
 	}
 
 	@Test
-	public void testParseObject() {
+	public void testParseObject() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/catalystActivity.xml");
 			ReactomeCatalystActivity res = parser.parseObject(document.getChildNodes().item(0));
@@ -37,12 +37,12 @@ public class ReactomeCatalystActivityParserTest extends ReactomeTestFunctions{
 			assertEquals((Integer)162843,res.getPhysicalEntity().getDbId());
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
 	@Test
-	public void testUpdateObjectFromDb() {
+	public void testUpdateObjectFromDb() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/catalystActivity.xml");
 			ReactomeCatalystActivity res = parser.parseObject(document.getChildNodes().item(0));
@@ -54,7 +54,7 @@ public class ReactomeCatalystActivityParserTest extends ReactomeTestFunctions{
 			
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
diff --git a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeDefinedSetParserTest.java b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeDefinedSetParserTest.java
index a0c0087478..a8923e80b3 100644
--- a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeDefinedSetParserTest.java
+++ b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeDefinedSetParserTest.java
@@ -29,7 +29,7 @@ public class ReactomeDefinedSetParserTest extends ReactomeTestFunctions {
 	}
 
 	@Test
-	public void testParseObject() {
+	public void testParseObject() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/definedSet.xml");
 			ReactomeDefinedSet res = parser.parseObject(document.getChildNodes().item(0));
@@ -49,12 +49,12 @@ public class ReactomeDefinedSetParserTest extends ReactomeTestFunctions {
 
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
 	@Test
-	public void testUpdateObjectFromDb() {
+	public void testUpdateObjectFromDb() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/definedSet.xml");
 			ReactomeDefinedSet res = parser.parseObject(document.getChildNodes().item(0));
@@ -71,7 +71,7 @@ public class ReactomeDefinedSetParserTest extends ReactomeTestFunctions {
 
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
diff --git a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeGenomeEncodedEntityParserTest.java b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeGenomeEncodedEntityParserTest.java
index 5c914801de..97b012230b 100644
--- a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeGenomeEncodedEntityParserTest.java
+++ b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeGenomeEncodedEntityParserTest.java
@@ -29,7 +29,7 @@ public class ReactomeGenomeEncodedEntityParserTest extends ReactomeTestFunctions
 	}
 
 	@Test
-	public void testParseObject() {
+	public void testParseObject() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/genomeEncodedEntity.xml");
 			ReactomeGenomeEncodedEntity res = parser.parseObject(document.getChildNodes().item(0));
@@ -43,12 +43,12 @@ public class ReactomeGenomeEncodedEntityParserTest extends ReactomeTestFunctions
 			assertEquals("unidentified caspase acting on ZO-2",res.getNames().get(0));
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
 	@Test
-	public void testUpdateObjectFromDb() {
+	public void testUpdateObjectFromDb() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/genomeEncodedEntity.xml");
 			ReactomeGenomeEncodedEntity res = parser.parseObject(document.getChildNodes().item(0));
@@ -62,7 +62,7 @@ public class ReactomeGenomeEncodedEntityParserTest extends ReactomeTestFunctions
 			
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
diff --git a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeOtherEntityParserTest.java b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeOtherEntityParserTest.java
index 04731d17e0..befdce0974 100644
--- a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeOtherEntityParserTest.java
+++ b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomeOtherEntityParserTest.java
@@ -29,7 +29,7 @@ public class ReactomeOtherEntityParserTest extends ReactomeTestFunctions{
 	}
 
 	@Test
-	public void testParseObject() {
+	public void testParseObject() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/otherEntity.xml");
 			ReactomeOtherEntity res = parser.parseObject(document.getChildNodes().item(0));
@@ -45,12 +45,12 @@ public class ReactomeOtherEntityParserTest extends ReactomeTestFunctions{
 			
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
 	@Test
-	public void testUpdateObjectFromDb() {
+	public void testUpdateObjectFromDb() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/otherEntity.xml");
 			ReactomeOtherEntity res = parser.parseObject(document.getChildNodes().item(0));
@@ -64,7 +64,7 @@ public class ReactomeOtherEntityParserTest extends ReactomeTestFunctions{
 			
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
diff --git a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomePathwayParserTest.java b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomePathwayParserTest.java
index 4a2ba2564a..3342858e30 100644
--- a/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomePathwayParserTest.java
+++ b/reactome/src/test/java/lcsb/mapviewer/reactome/xml/ReactomePathwayParserTest.java
@@ -28,7 +28,7 @@ public class ReactomePathwayParserTest extends ReactomeTestFunctions{
 	}
 
 	@Test
-	public void testParseObject() {
+	public void testParseObject() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/pathway.xml");
 			ReactomePathway res = parser.parseObject(document.getChildNodes().item(0));
@@ -50,7 +50,7 @@ public class ReactomePathwayParserTest extends ReactomeTestFunctions{
 			
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 	
@@ -65,7 +65,7 @@ public class ReactomePathwayParserTest extends ReactomeTestFunctions{
 	}
 
 	@Test
-	public void testUpdateObjectFromDb() {
+	public void testUpdateObjectFromDb() throws Exception {
 		try {
 			Document document = getXmlDocumentFromFile("testFiles/reactome/pathway.xml");
 			ReactomePathway res = parser.parseObject(document.getChildNodes().item(0));
@@ -83,7 +83,7 @@ public class ReactomePathwayParserTest extends ReactomeTestFunctions{
 			
 		} catch (Exception e) {
 			e.printStackTrace();
-			fail("Unknown exception");
+			throw e;
 		}
 	}
 
-- 
GitLab