From 8efe832a40cab61f0e8cfc3d55e1319b19f803df Mon Sep 17 00:00:00 2001
From: Piotr Gawron <piotr.gawron@uni.lu>
Date: Wed, 11 Jan 2017 16:49:29 +0100
Subject: [PATCH] refacor to remove function creation inside loop
---
frontend-js/src/main/js/map/CustomMap.js | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/frontend-js/src/main/js/map/CustomMap.js b/frontend-js/src/main/js/map/CustomMap.js
index 6c9b0d4a27..a496b3a4f2 100644
--- a/frontend-js/src/main/js/map/CustomMap.js
+++ b/frontend-js/src/main/js/map/CustomMap.js
@@ -460,17 +460,16 @@ CustomMap.prototype.registerSource = function(overlayCollection) {
CustomMap.prototype.refreshComments = function() {
var self = this;
- for ( var overlayName in this.overlayCollections) {
- if (this.overlayCollections.hasOwnProperty(overlayName) && overlayName === "comment") {
- var collection = this.overlayCollections[overlayName];
- self.clearOverlayCollection(collection);
- if (ServerConnector.getSessionData(self.getProject()).getShowComments()) {
- return collection.refresh().then(function(){
- return self.renderOverlayCollection({overlayCollection:collection});
- });
- } else {
- return collection.clear();
- }
+
+ var collection = self.getOverlayByName("comment");
+ if (collection!==undefined) {
+ self.clearOverlayCollection(collection);
+ if (ServerConnector.getSessionData(self.getProject()).getShowComments()) {
+ return collection.refresh().then(function(){
+ return self.renderOverlayCollection({overlayCollection:collection});
+ });
+ } else {
+ return collection.clear();
}
}
throw new Error("comment OverlayCollection not found");
--
GitLab