Reaction contructor throws errors instead of logging them

frontend-js/src/main/js/map/data/Reaction.js

@@ -32,7 +32,7 @@ function Reaction(javaObject) {
       } else if (line.type === "MIDDLE") {
         this.midLines.push(line);
       } else {
-        logger.error("Unknown line type: " + line.type);
+        throw new Error("Unknown line type: " + line.type);
       }
     }
     this.setCenter(javaObject.centerPoint);
@@ -72,7 +72,7 @@ Reaction.prototype.getEndLines = function() {
 
 Reaction.prototype.setCenter = function(center) {
   if (center === null || center === undefined) {
-    logger.error("Setting undefined center: ", center);
+    throw new Error("Setting undefined center: ", center);
   }
   this._center = center;
 };

frontend-js/src/test/js/map/data/Reaction-test.js

 "use strict";
 
+var Helper = require('../../Helper');
+
+require("../../mocha-config.js");
+
 var Reaction = require('../../../../main/js/map/data/Reaction');
 var assert = require('assert');
 
@@ -7,6 +11,12 @@ var logger = require('../../logger');
 
 describe('Reaction', function() {
 
+  var helper;
+  before(function() {
+    helper = new Helper();
+  });
+
+  
   it("contructor", function() {
     var javaObject = {
       lines : [ {
@@ -23,48 +33,34 @@ describe('Reaction', function() {
         type : "MIDDLE"
       } ],
       modelId : 319,
-      idObject : "13178"
+      idObject : "13178",
+      centerPoint : {
+        x : 10,
+        y : 12,
+      },
     };
     var reaction = new Reaction(javaObject);
     assert.ok(reaction);
     assert.ok(reaction.getId());
   });
-  it("contructor from invalid", function() {
+  it("constructor from invalid", function() {
     var javaObject = {
       lines : [ {
         start : Object,
         end : Object,
         type : "UNK"
       } ],
-    
+
     };
-    new Reaction(javaObject);
-    assert.equal(logger.getErrors().length, 2);
+    try {
+      new Reaction(javaObject);
+    } catch (exception) {
+      assert.ok(exception.message.indexOf("Unknown line type") >= 0);
+    }
   });
 
-  it("contructor from Reaction", function() {
-    var javaObject = {
-      centerPoint : {
-        x : 1,
-        y : 2
-      },
-      lines : [ {
-        start : Object,
-        end : Object,
-        type : "START"
-      }, {
-        start : Object,
-        end : Object,
-        type : "END"
-      }, {
-        start : Object,
-        end : Object,
-        type : "MIDDLE"
-      } ],
-      modelId : 319,
-      idObject : "13178"
-    };
-    var reaction = new Reaction(javaObject);
+  it("constructor from Reaction", function() {
+    var reaction = helper.createReaction();
     var reaction2 = new Reaction(reaction);
     assert.equal(reaction2.getId(), reaction.getId());
     assert.equal(reaction2.getCenter(), reaction.getCenter());

frontend-js/src/test/js/map/overlay/ReactionOverlay-test.js

@@ -71,25 +71,7 @@ describe('ReactionOverlay', function() {
   it("Constructor 2", function() {
     var map = helper.createAbstractCustomMap();
 
-    var javaObject = {
-      lines : [ {
-        start : Object,
-        end : Object,
-        type : "START"
-      }, {
-        start : Object,
-        end : Object,
-        type : "END"
-      }, {
-        start : Object,
-        end : Object,
-        type : "MIDDLE"
-      } ],
-      modelId : 319,
-      idObject : "13178"
-    };
-
-    var react = new Reaction(javaObject);
+    var react = helper.createReaction();
     var reaction = new ReactionOverlay(null, react, map, false);
 
     assert.ok(reaction.gmapObjects);