Skip to content
Snippets Groups Projects
Commit c90da2cf authored by Piotr Gawron's avatar Piotr Gawron
Browse files

rejection when highlighting with invalid model id

parent af740131
No related branches found
No related tags found
1 merge request!34Resolve "when highligting element that doesn't exist throw an error"
......@@ -56,7 +56,11 @@ UserDbOverlay.prototype._createIdentifiedElements = function(params, sourceArray
return Promise.reject(new Error("Element already highlighted: " + element.getId()));
}
result.push(element);
promises.push(self.getMap().getSubmapById(element.getModelId()).getModel().getByIdentifiedElement(element));
var submap = self.getMap().getSubmapById(element.getModelId());
if (submap === null) {
return Promise.reject(new InvalidArgumentError("Submap doesn't exist: " + result[i].getModelId()));
}
promises.push(submap.getModel().getByIdentifiedElement(element));
}
return Promise.all(promises).then(function(elementsFromModel) {
for (var i = 0; i < elementsFromModel.length; i++) {
......
......@@ -85,4 +85,30 @@ describe('UserDbOverlay', function() {
});
});
it("add to unexisting map", function() {
var overlay;
return ServerConnector.getProject().then(function(project) {
var options = helper.createCustomMapOptions(project);
var map = new CustomMap(options);
overlay = new UserDbOverlay({
map : map,
name : 'user'
});
return overlay.addMarker({
element : {
id : 329171,
modelId : -1,
type : "ALIAS"
},
options : {
type : "SURFACE"
}
});
}).then(function() {
assert.ok(false, "Exception expected");
}, function(error) {
assert.ok(error instanceof InvalidArgumentError)
});
});
});
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment