Merge branch 'MIN-238-normalize-data-fetched-for-overlays' into 'development'

feat(overlaybioentity): add util to get validated overlay bio entities

See merge request !104

src/redux/overlayBioEntity/overlayBioEntity.thunk.ts

 import { createAsyncThunk } from '@reduxjs/toolkit';
-import { z } from 'zod';
 import { axiosInstanceNewAPI } from '@/services/api/utils/axiosInstance';
 import { OverlayBioEntity } from '@/types/models';
-import { overlayBioEntitySchema } from '@/models/overlayBioEntitySchema';
-import { validateDataUsingZodSchema } from '@/utils/validateDataUsingZodSchema';
 import { OverlayBioEntityRender } from '@/types/OLrendering';
-import { parseOverlayBioEntityToOlRenderingFormat } from './overlayBioEntity.utils';
+import {
+  getValidOverlayBioEntities,
+  parseOverlayBioEntityToOlRenderingFormat,
+} from './overlayBioEntity.utils';
 import { apiPath } from '../apiPath';
 import { modelsIdsSelector } from '../models/models.selectors';
 import type { RootState } from '../store';
@@ -27,10 +27,10 @@ export const getOverlayBioEntity = createAsyncThunk(
       apiPath.getOverlayBioEntity({ overlayId, modelId }),
     );
 
-    const isDataValid = validateDataUsingZodSchema(response.data, z.array(overlayBioEntitySchema));
+    const validOverlayBioEntities = getValidOverlayBioEntities(response.data);
 
-    if (isDataValid) {
-      return parseOverlayBioEntityToOlRenderingFormat(response.data, overlayId);
+    if (validOverlayBioEntities) {
+      return parseOverlayBioEntityToOlRenderingFormat(validOverlayBioEntities, overlayId);
     }
 
     return undefined;

src/redux/overlayBioEntity/overlayBioEntity.utils.test.ts

-import { calculateOvarlaysOrder } from './overlayBioEntity.utils';
+import { overlayBioEntityFixture } from '@/models/fixtures/overlayBioEntityFixture';
+import { OverlayBioEntity } from '@/types/models';
+import { calculateOvarlaysOrder, getValidOverlayBioEntities } from './overlayBioEntity.utils';
 
 describe('calculateOverlaysOrder', () => {
   const cases = [
@@ -62,3 +64,37 @@ describe('calculateOverlaysOrder', () => {
     expect(calculateOvarlaysOrder(data)).toStrictEqual(expected);
   });
 });
+
+describe('getValidOverlayBioEntities', () => {
+  it('should return empty array if overlayBioEntities are empty array', () => {
+    const result = getValidOverlayBioEntities([]);
+
+    expect(result).toEqual([]);
+  });
+  it('should return the same overlayBioEntities if all overlayBioEntities are valid', () => {
+    const result = getValidOverlayBioEntities(overlayBioEntityFixture);
+    expect(result).toEqual(overlayBioEntityFixture);
+  });
+  it('should filter properly and return valid overlayBioEntities if overlayBioEntities are mixed array with valid and invalid entities', () => {
+    const invalidOverlayBioEntities = overlayBioEntityFixture.map(overlayBioEntity => ({
+      ...overlayBioEntity,
+      left: {},
+    })) as OverlayBioEntity[];
+
+    const result = getValidOverlayBioEntities([
+      ...overlayBioEntityFixture,
+      ...invalidOverlayBioEntities,
+    ]);
+    expect(result).toEqual(overlayBioEntityFixture);
+  });
+  it('should return empty array if all overlayBioEntities are invalid', () => {
+    const invalidOverlayBioEntities = overlayBioEntityFixture.map(overlayBioEntity => ({
+      ...overlayBioEntity,
+      right: {},
+    })) as OverlayBioEntity[];
+
+    const result = getValidOverlayBioEntities(invalidOverlayBioEntities);
+
+    expect(result).toEqual([]);
+  });
+});

src/redux/overlayBioEntity/overlayBioEntity.utils.ts

 import { ONE } from '@/constants/common';
+import { overlayBioEntitySchema } from '@/models/overlayBioEntitySchema';
 import { OverlayBioEntityRender } from '@/types/OLrendering';
 import { OverlayBioEntity } from '@/types/models';
+import { z } from 'zod';
 
 export const parseOverlayBioEntityToOlRenderingFormat = (
   data: OverlayBioEntity[],
@@ -66,3 +68,23 @@ export const calculateOvarlaysOrder = (
 
   return overlaysOrder;
 };
+
+const isValidOverlayBioEntity = (overlayBioEntity: OverlayBioEntity): boolean => {
+  return overlayBioEntitySchema.safeParse(overlayBioEntity).success;
+};
+
+type OverlayBioEntities = OverlayBioEntity[];
+
+export const getValidOverlayBioEntities = (
+  unvalidatedOverlayBioEntities: OverlayBioEntities,
+): OverlayBioEntities | undefined => {
+  const filteredValidOverlayBioEntitiesSchema = z
+    .array(z.any())
+    .transform(overlayBioEntities => overlayBioEntities.filter(isValidOverlayBioEntity));
+
+  const parsedOverlayBioEntities = filteredValidOverlayBioEntitiesSchema.safeParse(
+    unvalidatedOverlayBioEntities,
+  );
+
+  return parsedOverlayBioEntities.success ? parsedOverlayBioEntities.data : undefined;
+};