Skip to content
Snippets Groups Projects

fix(search bar): fixed unexpected search bar openings & lack of search value in input on load

Merged Tadeusz Miesiąc requested to merge fix/search-bar-query-params into development
1 unresolved thread

Description

Fixed two bugs Opening a map from URL without a pin/search forces empty search URL with search results does not fill out the search bar

when searchValue is empty it no longer shows in queryParams

Merge request reports

Merge request pipeline #84458 passed

Merge request pipeline passed for 86096805

Test coverage 91.77% (0.03%) from 1 job

Merged by Tadeusz MiesiącTadeusz Miesiąc 1 year ago (Jan 17, 2024 8:11am UTC)

Loading

Pipeline #84466 passed

Pipeline passed for 33a6d7f2 on development

Test coverage 91.77% (0.03%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
19 19 const queryDataParams: QueryDataParams = {
20 searchValue: searchValue.join(';'),
21 20 perfectMatch,
22 21 modelId,
23 22 backgroundId,
24 23 ...position.last,
25 24 };
26 25
26 /** prevent searchValueQuery from being empty */
27 if (searchValue.length > ZERO) {
28 const joinedSearchValue = searchValue.join(';');
29 if (joinedSearchValue) {
30 queryDataParams.searchValue = joinedSearchValue;
31 }
32 }
33
  • Concept is OK, but IMO we should make it cleaner

    my comment is an RFC

  • Adrian Orłów approved this merge request

    approved this merge request

  • LGTM, RFC - Adrian's comment

  • mateusz-winiarczyk approved this merge request

    approved this merge request

  • Tadeusz Miesiąc added 24 commits

    added 24 commits

    • 833efb35...d6dd7738 - 22 commits from branch development
    • 6b0a3cf0 - Merge branch 'development' into fix/search-bar-query-params
    • 86096805 - refactor(query selector): improved code readability

    Compare with previous version

  • Tadeusz Miesiąc enabled an automatic merge when the pipeline for 86096805 succeeds

    enabled an automatic merge when the pipeline for 86096805 succeeds

  • Tadeusz Miesiąc mentioned in commit 33a6d7f2

    mentioned in commit 33a6d7f2

  • Please register or sign in to reply
    Loading