Skip to content
Snippets Groups Projects

feat: Add submap connections (MIN-276)

All threads resolved!

Closes MIN-276

Objective:

Implement rendering pins for submap links to maps with at least one searched element

What has been done:

  • submap connections state management
  • selectors for finding number of active elements per map and submap links for render
  • rendering of submap links pins
  • unit tests

Important:

Why getSubmapConnectionsBioEntity reducer is implemented weird way? Because adding submapConnections as required field would also imply fixing >85 different tests which I've viewed as more dangerous than defining this field as optional with additional actions made in the reducer

This PR is based on !163 (merged) so some changes may not be relevant to submap connections feature if !163 (merged) is not merged

image

Edited by Adrian Orłów

Merge request reports

Merge request pipeline #88175 passed

Merge request pipeline passed for f0c9fe06

Test coverage 90.40% (-0.41%) from 1 job
Approval is optional

Merged by Adrian OrłówAdrian Orłów 1 year ago (Mar 29, 2024 11:10am UTC)

Merge details

  • Changes merged into development with c087e2ac.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #88177 passed

Pipeline passed for c087e2ac on development

Test coverage 90.40% (-0.41%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • LGTM, RFC: please check if doubled dispatch(getSubmapConnectionsBioEntity()) call is needed, because request is doubled.

  • mateusz-winiarczyk approved this merge request

    approved this merge request

  • Adrian Orłów resolved all threads

    resolved all threads

  • Adrian Orłów added 9 commits

    added 9 commits

    Compare with previous version

  • Adrian Orłów enabled an automatic merge when the pipeline for f0c9fe06 succeeds

    enabled an automatic merge when the pipeline for f0c9fe06 succeeds

  • Adrian Orłów mentioned in commit c087e2ac

    mentioned in commit c087e2ac

  • merged

  • Please register or sign in to reply
    Loading