Skip to content
Snippets Groups Projects

fix(plugin): opening plugin from url (MIN-307)

Merged mateusz-winiarczyk requested to merge MIN-307-opening-plugin-from-url into development

We check whether the script url and the url in the script itself match. If not, we will not have the url from inside the script in the hash map hashedPlugins and we will throw an error that the urls do not match. This will prevent plugins with non-matching urls from being loaded and will prevent an error in which the undefined hash is sent to the backend because the url was not found in the hash map and therefore undefined was sent to the backend in the registerPlugin method.

error-plugin-url-match

Closes MIN-307

Merge request reports

Merge request pipeline #88576 passed

Merge request pipeline passed for a022caa0

Test coverage 90.36% (0.00%) from 1 job
Approval is optional

Merged by mateusz-winiarczykmateusz-winiarczyk 1 year ago (Apr 9, 2024 9:19am UTC)

Merge details

  • Changes merged into development with 535217d5 (commits were squashed).
  • Deleted the source branch.

Pipeline #88592 passed

Pipeline passed for 535217d5 on development

Test coverage 90.36% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading