feat(results 2nd step): created dummy component for results
Description
Added dummy component for results 2nd step
Merge request reports
Activity
requested review from @AdrianOrlow and @mateuszmiko
1 import { DrawerHeadingBackwardButton } from '@/shared/DrawerHeadingBackwardButton'; 2 import { PinsList } from './PinsList'; 3 4 const PINS_LIST = [ changed this line in version 2 of the diff
- src/shared/Icon/Icons/PinOrance.tsx 0 → 100644
1 interface PinOrangeProps { 2 className: string; 3 } 4 5 export const PinOrange = ({ className }: PinOrangeProps): JSX.Element => ( 6 <svg 7 width="18" 8 height="24" 9 viewBox="0 0 18 24" 10 fill="none" 11 xmlns="http://www.w3.org/2000/svg" 12 className={className} 13 > 14 <path 15 d="M9 0C4.575 0 0 3.375 0 9C0 14.325 8.1 22.65 8.475 23.025C8.625 23.175 8.775 23.25 9 23.25C9.225 23.25 9.375 23.175 9.525 23.025C9.9 22.65 18 14.4 18 9C18 3.375 13.425 0 9 0ZM9 12C7.35 12 6 10.65 6 9C6 7.35 7.35 6 9 6C10.65 6 12 7.35 12 9C12 10.65 10.65 12 9 12Z" 16 fill="#E17221" changed this line in version 2 of the diff
1 import { useAppDispatch } from '@/redux/hooks/useAppDispatch'; 2 import { closeDrawer } from '@/redux/drawer/drawer.slice'; 3 import { IconButton } from '@/shared/IconButton'; 4 5 export const CLOSE_BUTTON_ROLE = 'close-drawer-button'; 6 export const BACK_BUTTON_ROLE = 'back-button'; changed this line in version 2 of the diff
- src/utils/getReduxWrapperWithStore.tsx 0 → 100644
9 import projectReducer from '@/redux/project/project.slice'; 10 import searchReducer from '@/redux/search/search.slice'; 11 import modelsReducer from '@/redux/models/models.slice'; 12 import { SearchState } from '@/redux/search/search.types'; 13 import { ProjectState } from '@/redux/project/project.types'; 14 import { DrugsState } from '@/redux/drugs/drugs.types'; 15 import { MirnasState } from '@/redux/mirnas/mirnas.types'; 16 import { ChemicalsState } from '@/redux/chemicals/chemicals.types'; 17 import { BioEntityContentsState } from '@/redux/bioEntityContents/bioEntityContents.types'; 18 import { DrawerState } from '@/redux/drawer/drawer.types'; 19 20 interface WrapperProps { 21 children: React.ReactNode; 22 } 23 24 export type InitialStoreState = { -
I see two issues here:
-
IMO this type shouldn't be a part of the util if we need to use it outside the util file. It would be better to extract it to more global file as
redux.tswhereStoreTypeis defined -
It's a clone of original store structure - on any new store structure change, we'll need to update this type also. IMO it would be better to
Pick<>this type from the originalStoreTypeor defineInitialStoreStateglobally in theredux.tsfile
-
changed this line in version 2 of the diff
enabled an automatic merge when the pipeline for fde4c9a8 succeeds
mentioned in commit fabf5541
