Resolve "remove usage of old reaction endpoint" (!311) · Merge requests · minerva / frontend · GitLab

Snippets Groups Projects

Merged Piotr Gawron requested to merge 316-remove-usage-of-old-reaction-endpoint into development 5 months ago

All threads resolved!

Closes #316 (closed)

Approval is optional

Pipeline #98260 passed

Pipeline passed for 54a892c7 on development 4 months ago

Test coverage 87.58% (-0.08%) from 1 job

Activity

Piotr Gawron changed milestone to %v19.0.0~alpha.0 5 months ago

changed milestone to %v19.0.0~alpha.0
Piotr Gawron added 5 commits 5 months ago
added 5 commits

6ba67e87 - usage of old reaction endpoint removed

c67476a3 - reactionSchema removed (it has been taken from old API)

16f01b2c - productSchema deleted in favor of reactionProductSchema

12b5b595 - zoom factor is rescaled

db888f72 - getReactionByIdInNewApi apiPath replaced by getNewReaction apiPath

Compare with previous version
Toggle commit list
Piotr Gawron marked this merge request as ready 5 months ago

marked this merge request as ready
Piotr Gawron requested review from @MGrocholewski 5 months ago

requested review from @MGrocholewski
Miłosz Grocholewski @MGrocholewski started a thread on the diff 5 months ago

Resolved 4 months ago by Piotr Gawron
Last reply by Piotr Gawron 4 months ago

Miłosz Grocholewski @MGrocholewski started a thread on an old version of a file 5 months ago

Resolved 4 months ago by Piotr Gawron

Miłosz Grocholewski @MGrocholewski · 5 months ago

Developer

The reactionLineSchema can be removed and the model based on this schema from models.ts

Piotr Gawron added 5 commits 4 months ago

added 5 commits

db888f72...983e1065 - 2 commits from branch development
277a6d9f - rmeove reactionLineSchema
2818e12f - Merge remote-tracking branch 'origin/development' into 316-remove-usage-of-old-reaction-endpoint
6393e8be - remove getBioEntitiesIdsFromReaction in favor of getModelElementsIdsFromReaction

Compare with previous version

Toggle commit list

Piotr Gawron resolved all threads 4 months ago

resolved all threads

Piotr Gawron merged 4 months ago

merged

Piotr Gawron mentioned in commit 4 months ago

mentioned in commit 54a892c7

Please register or sign in to reply