Skip to content
Snippets Groups Projects

Feature/perfect match

Merged Feature/perfect match
feature/perfect-match into feature/multisearch
2 unresolved threads
Merged Tadeusz Miesiąc requested to merge feature/perfect-match into feature/multisearch
2 unresolved threads

Description

Added ability to fetch data that matches perfectly the search value

Usage

  • After first search, user is able to search for new values with perfect match
  • when clicking on switch - no query is triggered. User must click search again. This is original functionality

Things done

  • Added switch component
  • Added new query param perfectMatch

Merge request reports

Merge request pipeline #81697 passed

Stage: lint
    Stage: prettier
      Stage: test

        Merge request pipeline passed for 62207997

        Test coverage 91.44% from 1 job
        Approved by
        Adrian Orłów

        Merged by Tadeusz MiesiącTadeusz Miesiąc 1 year ago (Nov 21, 2023 9:36am UTC)

        Merge details

        • Changes merged into feature/multisearch with 590a3eff.
        • Deleted the source branch.

        Pipeline #81746 passed

        Stage: lint

          Pipeline passed for 590a3eff on feature/multisearch

          Activity

          Filter activity
          • Approvals
          • Assignees & reviewers
          • Comments (from bots)
          • Comments (from users)
          • Commits & branches
          • Edits
          • Labels
          • Lock status
          • Mentions
          • Merge request status
          • Tracking
          src/redux/root/init.thunks.ts
          42 43
          43 44 /** Trigger search */
          44 45 if (queryData.searchValue) {
        • Adrian Orłów
          Adrian Orłów @AdrianOrlow started a thread on the diff
          • src/redux/apiPath.ts
          1 1 import { PROJECT_ID } from '@/constants';
          2 import { PerfectSearchParams } from '@/types/search';
          2 3
          3 4 export const apiPath = {
          4 getBioEntityContentsStringWithQuery: (searchQuery: string): string =>
          5 `projects/${PROJECT_ID}/models/*/bioEntities/:search?query=${searchQuery}&size=1000`,
          5 getBioEntityContentsStringWithQuery: ({
          6 searchQuery,
          7 isPerfectMatch,
          8 }: PerfectSearchParams): string =>
          9 `projects/${PROJECT_ID}/models/*/bioEntities/:search?query=${searchQuery}&size=1000&perfectMatch=${isPerfectMatch}`,
        • Adrian Orłów
        • Adrian Orłów
          Adrian Orłów @AdrianOrlow ·
          Developer

          LGTM - great work

        • Adrian Orłów approved this merge request

          approved this merge request

        • Tadeusz Miesiąc mentioned in commit 590a3eff

          mentioned in commit 590a3eff

        • Tadeusz Miesiąc merged

          merged

          • Please register or sign in to reply