Feature/search bioentities details
List and details of bio entities.
We cannot treat bio entities in the same way as mirna, chemicals or drugs. Thats why I decided to save list of all bio entities in store after clicking on individual submap.
I separated the components for bioEntities from the others (MiRNA, chemicals, drugs). Now, at the SearchDrawerWrapper component level, we have separate components:
-
ResultsListfor drugs, chemicals and MiRNA -
BioEntitiesResultsListfor bio entites
Merge request reports
Activity
assigned to @MateuszBolewski
15 <Wrapper> 16 <BioEntitiesSubmapItem 17 mapName="main map" 18 numberOfEntities={21} 19 bioEntities={bioEntitiesContentFixture} 20 /> 21 </Wrapper>, 22 ), 23 { 24 store, 25 } 26 ); 27 }; 9 28 10 29 describe('BioEntitiesSubmapItem - component', () => { 11 30 it('should display map name,number of elements, icon', () => { 14 render( 15 <Wrapper> 16 <BioEntitiesSubmapItem 17 mapName="main map" 18 numberOfEntities={21} 19 bioEntities={bioEntitiesContentFixture} 20 /> 21 </Wrapper>, 22 ), 23 { 24 store, 25 } 26 ); 27 }; 9 28 10 29 describe('BioEntitiesSubmapItem - component', () => { 9 13 mapName, 10 14 numberOfEntities, 11 }: BioEntitiesSubmapItemProps): JSX.Element => ( 12 <div className="flex flex-row flex-nowrap justify-between pl-6 [&:not(:last-of-type)]:pb-4"> 13 <p> 14 {mapName} ({numberOfEntities}) 15 </p> 16 <Icon name="arrow" className="h-6 w-6 fill-font-500" /> 17 </div> 18 ); 15 bioEntities, 16 }: BioEntitiesSubmapItemProps): JSX.Element => { 17 const dispatch = useAppDispatch(); 18 19 const onSubmapClick = (): void => { 20 dispatch(displayBioEntitiesList(bioEntities)); 3 import { PinType } from './PinsList.types'; 4 5 interface BioEntitiesPinsListProps { 6 bioEnititesPins: BioEntityContent[]; 7 type: PinType; 8 } 9 10 export const BioEntitiesPinsList = ({ 11 bioEnititesPins, 12 type, 13 }: BioEntitiesPinsListProps): JSX.Element => { 14 return ( 15 <ul className="h-[calc(100vh-198px)] overflow-auto px-6 py-2"> 16 {bioEnititesPins && 17 bioEnititesPins.map(result => ( 18 <MirnaPinsListItem changed this line in version 4 of the diff
26 26 case 'bioEntity': 27 27 return <div />; 28 28 case 'chemicals': 29 return <div />; 29 return ( 30 <div className="h-[calc(100vh-198px)] overflow-auto"> 31 <AccordionsDetails pinsList={pinsList} type={type} /> 32 <ul className="px-6 py-2"> 33 {pinsList.map(result => { 34 return result.data.targets.map(pin => ( 35 <MirnaPinsListItem key={pin.name} name={pin.name} type={type} pin={pin} /> 36 )); 1 import { BioEntityContent } from '@/types/models'; 2 import { MirnaPinsListItem } from './PinsListItem'; 3 import { PinType } from './PinsList.types'; 4 5 interface BioEntitiesPinsListProps { 6 bioEnititesPins: BioEntityContent[]; 7 type: PinType; 8 } 9 10 export const BioEntitiesPinsList = ({ changed this line in version 4 of the diff
-
RFC: MirnaPinsListItem functions inside component issues if there's no rationale behind
Overall LGTM but a lot of tests are lacking - please add them whenever possible
Edited by Adrian Orłów 
-
Logic works as intended. There is few simplification of components you can implement and wrong naming. Thats RFC from my side.
Btw. It's good idea to refresh Boy scout rule I cathed few places that could be easily fixed/improved with small amount of effort during development, but probably not all of them.
added 11 commits
-
3426bb5e...c33dca6f - 10 commits from branch
development - 657d9540 - Merge branch 'development' of ssh://gitlab.lcsb.uni.lu:8022/minerva/frontend...
-
3426bb5e...c33dca6f - 10 commits from branch
added 1 commit
- d5c54f4e - feat(search): splitted component for bio entites from rest pins
added 8 commits
-
99c2573d...fcd1b12f - 7 commits from branch
development - 22758614 - Merge branch 'development' of ssh://gitlab.lcsb.uni.lu:8022/minerva/frontend...
-
99c2573d...fcd1b12f - 7 commits from branch
enabled an automatic merge when the pipeline for 22758614 succeeds
mentioned in commit ae10651f