feat(bioentity:submaplink): allow user to open submap by clicking on submaplink on map
3 unresolved threads
Description
When clicking on submap link on map -> should display bioEntityDrawer with open submap button which allow user to open submap
Things done
- implemented functionality
- created hook
openSubmap
-> it should be used for gradual refactor for openSubmap functionality. We repeat code in few places in the app. Skipped replacing it cuz it would require to spend some more time - extracted part of BioEntity drawer to separate component - Annotation Item
Merge request reports
Activity
Filter activity
requested review from @AdrianOrlow and @MateuszBolewski
- Resolved by Tadeusz Miesiąc
60 }); 61 it('should render component when associated map model is found', () => { 62 renderComponent({ 63 bioEntity: { 64 ...BIOENTITY_INITIAL_STATE_MOCK, 65 data: BIO_ENTITY_LINKING_TO_SUBMAP_DATA_MOCK, 66 }, 67 drawer: { 68 ...DRAWER_INITIAL_STATE, 69 bioEntityDrawerState: { 70 bioentityId: bioEntityContentFixture.bioEntity.id, 71 }, 72 }, 73 models: { 74 ...MODELS_INITIAL_STATE_MOCK, 75 data: MODELS_MOCK_SHORT, - Resolved by Tadeusz Miesiąc
- src/hooks/useOpenSubmaps.ts 0 → 100644
3 import { mapOpenedMapsSelector } from '@/redux/map/map.selectors'; 4 import { openMapAndSetActive, setActiveMap } from '@/redux/map/map.slice'; 5 import { modelsDataSelector } from '@/redux/models/models.selectors'; 6 import { useCallback } from 'react'; 7 8 type UseOpenSubmapProps = { 9 modelId: number | undefined; 10 modelName: string | undefined; 11 }; 12 13 type UseOpenSubmapReturnType = { 14 openSubmap: () => void; 15 isItPossibleToOpenMap: boolean; 16 }; 17 18 export const useOpenSubmap = ({ - src/hooks/useOpenSubmaps.ts 0 → 100644
12 13 type UseOpenSubmapReturnType = { 14 openSubmap: () => void; 15 isItPossibleToOpenMap: boolean; 16 }; 17 18 export const useOpenSubmap = ({ 19 modelId, 20 modelName, 21 }: UseOpenSubmapProps): UseOpenSubmapReturnType => { 22 const openedMaps = useAppSelector(mapOpenedMapsSelector); 23 const models = useAppSelector(modelsDataSelector); 24 const dispatch = useAppDispatch(); 25 26 const isMapAlreadyOpened = openedMaps.some(map => map.modelId === modelId); 27 const doesMapExist = models.some(model => model.idObject === modelId); changed this line in version 2 of the diff
- Resolved by Tadeusz Miesiąc
mentioned in merge request !75 (merged)
added 1 commit
- fbb8ffcd - feat(bioentity:submaplink): allow user to open submap by clicking on submaplink on map
enabled an automatic merge when the pipeline for fbb8ffcd succeeds
mentioned in commit 342e71d0
Please register or sign in to reply