Skip to content
Snippets Groups Projects

feat(overlays): add/remove overlay from store

Merged feat(overlays): add/remove overlay from store
overlays/add-remove-overlay-from-store into development
1 unresolved thread
Merged Tadeusz Miesiąc requested to merge overlays/add-remove-overlay-from-store into development
1 unresolved thread

Description

This PR focuses on adding functionality to manage overlayBioEntity state for multiple overlays. Bio entities are stored under key-value pairs as follows: export type OverlaysBioEntityState = { overlaysId: number[]; data: { [overlayId: number]: { [modelId: number]: OverlayBioEntityRender[]; }; }; }; This way it's easier to add and remove new overlays.

Things done

  • store management - adding / removing new overlays
  • toggling on/off overlays in drawer -> currently displays only first overlay

Things to consider during code review

OverlayListItem covers test cases for useOverlay hook.

Edited by Tadeusz Miesiąc

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/components/Map/Drawer/OverlaysDrawer/GeneralOverlays/OverlayListItem/hooks/useOverlay.ts 0 → 100644
1 import { useAppDispatch } from '@/redux/hooks/useAppDispatch';
2 import { useAppSelector } from '@/redux/hooks/useAppSelector';
3 import { isOverlayActiveSelector } from '@/redux/overlayBioEntity/overlayBioEntity.selector';
4 import { removeOverlayBioEntityForGivenOverlay } from '@/redux/overlayBioEntity/overlayBioEntity.slice';
5 import { getOverlayBioEntityForAllModels } from '@/redux/overlayBioEntity/overlayBioEntity.thunk';
6 import { useEmptyBackground } from './useEmptyBackground';
7
8 type UseOverlay = {
9 toggleOverlay: () => void;
10 isOverlayActive: boolean;
11 };
12
13 export const useOverlay = (overlayId: number): UseOverlay => {
  • Adrian Orłów
    Adrian Orłów @AdrianOrlow ·
    Developer

    I'm in favor of redundant test coverage, so IMO we should add unit tests for this hook. In the future this hook may be reused in different components and covering it's behavior only in one may be an issue

  • Please register or sign in to reply
  • Adrian Orłów
    Adrian Orłów @AdrianOrlow ·
    Developer

    LGTM. I'm in favor of additional test for useOverlay but that's NOT RFC

  • Adrian Orłów approved this merge request

    approved this merge request

  • Tadeusz Miesiąc merged

    merged

  • Tadeusz Miesiąc mentioned in commit e461460d

    mentioned in commit e461460d

    • Please register or sign in to reply