Skip to content
Snippets Groups Projects

fix(overlays): fixed opacity for overlays generated by entity color

Merged fix(overlays): fixed opacity for overlays generated by entity color
fix/overlays-color-alpha into development
1 unresolved thread
Merged Tadeusz Miesiąc requested to merge fix/overlays-color-alpha into development
1 unresolved thread

Description

When entity was generated for overlays by color - there was no alpha (opacity) value added. Fixed it.

Additional things done

Refactored color generating functions. We ended up in props drilling hell. Looking forward working on next features in overlays I decided to refactor code for maintainability

Merge request reports

Merge request pipeline #84490 passed

Stage: lint
    Stage: prettier
      Stage: test

        Merge request pipeline passed for 006f25a3

        Test coverage 92.12% (0.38%) from 1 job
        Approval is optional

        Merged by Tadeusz MiesiącTadeusz Miesiąc 1 year ago (Jan 17, 2024 11:40am UTC)

        Merge details

        • Changes merged into development with 42bfbca0.
        • Deleted the source branch.
        • Auto-merge enabled

        Pipeline #84491 passed

        Stage: lint
          Stage: prettier
            Stage: test
              Stage: deploy

                Pipeline passed for 42bfbca0 on development

                Test coverage 92.15% (0.38%) from 1 job

                Activity

                Filter activity
                • Approvals
                • Assignees & reviewers
                • Comments (from bots)
                • Comments (from users)
                • Commits & branches
                • Edits
                • Labels
                • Lock status
                • Mentions
                • Merge request status
                • Tracking
                src/components/Map/MapViewer/utils/config/overlaysLayer/useOverlayFeatures.ts 0 → 100644
                1 import { useMemo } from 'react';
                2 import { usePointToProjection } from '@/utils/map/usePointToProjection';
                3 import type Feature from 'ol/Feature';
                4 import type Polygon from 'ol/geom/Polygon';
                5 import { ZERO } from '@/constants/common';
                6 import { useAppSelector } from '@/redux/hooks/useAppSelector';
                7 import {
                8 getOverlayOrderSelector,
                9 overlayBioEntitiesForCurrentModelSelector,
                10 } from '@/redux/overlayBioEntity/overlayBioEntity.selector';
                11 import { createOverlayGeometryFeature } from './createOverlayGeometryFeature';
                12 import { getPolygonLatitudeCoordinates } from './getPolygonLatitudeCoordinates';
                13 import { useGetOverlayColor } from './useGetOverlayColor';
                14
                15 export const useOverlayFeatures = (): Feature<Polygon>[] => {
              • Adrian Orłów
                Adrian Orłów @AdrianOrlow ·
                Developer

                LGTM

                RFC: tests for useOverlayFeatures

                You may reuse part of tests from deleted getOverlayFeatures file

              • Adrian Orłów approved this merge request

                approved this merge request

              • mateusz-winiarczyk approved this merge request

                approved this merge request

              • mateusz-winiarczyk
                mateusz-winiarczyk @mateusz-winiarczyk ·
                Developer

                LGTM, RFC - Adrian's comment about tests for useOverlayFeatures.

              • Tadeusz Miesiąc added 1 commit

                added 1 commit

                • 7e6d4efe - test(useoverlayfeatures): added missing tests

                Compare with previous version

              • Tadeusz Miesiąc added 50 commits

                added 50 commits

                Compare with previous version

              • Tadeusz Miesiąc enabled an automatic merge when the pipeline for 006f25a3 succeeds

                enabled an automatic merge when the pipeline for 006f25a3 succeeds

              • Tadeusz Miesiąc merged

                merged

              • Tadeusz Miesiąc mentioned in commit 42bfbca0

                mentioned in commit 42bfbca0

                • Please register or sign in to reply