Skip to content
Snippets Groups Projects
Dennis Asamoah's avatar
  • beb3931a · add rp name for local development
Dennis Asamoah's avatar
  • 98b16007 · add webauthn RP settings to local_settings.py.template
Dennis Asamoah's avatar
Valentin Groues's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

Maybe add those to local_settings.py.template as webauthn is enabled by default and we should encourage people to customize those values.

Dennis Asamoah's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

sure

Valentin Groues's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

This should not be a migration file....

Piotr Gawron's avatar
closed merge request !369 "Draft: Resolve "change smash to smasch in code base"" at SMASCH / scheduling-system
Dennis Asamoah's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

...

Dennis Asamoah's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

A migration file was added to remove all 2 factors auth of all users....

Dennis Asamoah's avatar
Dennis Asamoah's avatar
Dennis Asamoah's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

Dennis Asamoah's avatar
Valentin Groues's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

ah I see, if the yubikeys never have an actual button that can be pushed, "touch" is indeed fine.

Valentin Groues's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

great, if not too much work, can you remove the method option altogether and set it directly to text message?

Valentin Groues's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

we don't want to change the settings.py on each instance, this one is tracked on git....

Valentin Groues's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

ah, I see. good point, forgot that even if 2fa is not forced, it is still available

Valentin Groues's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

ok, let's keep it like that then. maybe it's better to actually get an exception if someone remove the key from the settings.

Dennis Asamoah's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

We just have to change it in the settings.py directly for each instance of smasch deployed....

Dennis Asamoah's avatar
commented on merge request !466 "Add webauth" at SMASCH / scheduling-system

Yh but even if FORCE_2FA is false, user can still decide to add a 2fa and thus at least one 2fa method must be enabled in any case.