Skip to content
Snippets Groups Projects

Resolve "wrong start and end of reaction lines"

Merged Piotr Gawron requested to merge 812-wrong-start-and-end-of-reaction-lines into master

Closes #812 (closed) dear @david.hoksza,

This MR should resolve the problem. The root cause was ignoring layout of reaction with single line segment (in reaction part) when there were more than one product or more than one reactant.

However I found inconsistency in your SBML layout file. According to SBML specification(http://tinyurl.com/sbml-layout-rc2):

“product”, “sideproduct”, “substrate”, “sidesubstrate”, “undefined”: The line segments have their start element at the ReactionGlyph and their end element at the SpeciesGlyph.

But the point order in the submitted SBML file is reversed.

Edited by Piotr Gawron

Merge request reports

Pipeline #10203 passed

Pipeline passed for 4441b540 on 812-wrong-start-and-end-of-reaction-lines

Test coverage 76.14% (-0.02%) from 16 jobs
Approval is optional

Merged by Piotr GawronPiotr Gawron 5 years ago (May 13, 2019 5:26pm UTC)

Loading

Pipeline #10257 passed

Pipeline passed for eef024ad on master

Test coverage 76.11% (-0.02%) from 16 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading