code style issues

smash/web/api_views/subject.py

@@ -9,26 +9,26 @@ from web.views.subject import SUBJECT_LIST_GENERIC, SUBJECT_LIST_NO_VISIT, SUBJE
 
 
 @login_required
-def cities(request):
-    subjects = Subject.objects.filter(city__isnull=False).values_list('city').distinct()
+def cities():
+    result_subjects = Subject.objects.filter(city__isnull=False).values_list('city').distinct()
     return JsonResponse({
-        "cities": [x[0] for x in subjects]
+        "cities": [x[0] for x in result_subjects]
     })
 
 
 @login_required
-def countries(request):
-    subjects = Subject.objects.filter(country__isnull=False).values_list('country').distinct()
+def countries():
+    result_subjects = Subject.objects.filter(country__isnull=False).values_list('country').distinct()
     return JsonResponse({
-        "countries": [x[0] for x in subjects]
+        "countries": [x[0] for x in result_subjects]
     })
 
 
 @login_required
-def referrals(request):
-    subjects = Subject.objects.filter(referral__isnull=False).values_list('referral').distinct()
+def referrals():
+    result_subjects = Subject.objects.filter(referral__isnull=False).values_list('referral').distinct()
     return JsonResponse({
-        "referrals": [x[0] for x in subjects]
+        "referrals": [x[0] for x in result_subjects]
     })
 
 
@@ -135,12 +135,12 @@ def subjects(request, type):
         filtered_subjects = get_subjects_filtered(ordered_subjects, filters)
         sliced_subjects = filtered_subjects[start:(start + length)]
 
-        subjects = sliced_subjects
+        result_subjects = sliced_subjects
 
         count_filtered = filtered_subjects.count()
 
         data = []
-        for subject in subjects:
+        for subject in result_subjects:
             data.append(serialize_subject(subject))
 
         return JsonResponse({
@@ -154,7 +154,7 @@ def subjects(request, type):
 
 
 @login_required
-def types(request):
+def types():
     data = [{"id": subject_type_id, "name": subject_type_name} for subject_type_id, subject_type_name in
             SUBJECT_TYPE_CHOICES.items()]
     return JsonResponse({