Skip to content
Snippets Groups Projects
Commit 3d5ebb3e authored by Piotr Gawron's avatar Piotr Gawron
Browse files

indentation, unused code removed

parent 9e1d0d8b
No related branches found
No related tags found
1 merge request!336Pylint checks
...@@ -34,13 +34,13 @@ class AppointmentForm(ModelForm): ...@@ -34,13 +34,13 @@ class AppointmentForm(ModelForm):
for field in self.changed_data: for field in self.changed_data:
new_value = self.cleaned_data[field] or self.data[field] new_value = self.cleaned_data[field] or self.data[field]
if isinstance(new_value, QuerySet): if isinstance(new_value, QuerySet):
new_human_values = '; '.join([str(element) for element in new_value]) new_human_values = '; '.join([str(element) for element in new_value])
new_value = ','.join([str(element.id) for element in new_value]) #overwrite variable new_value = ','.join([str(element.id) for element in new_value]) #overwrite variable
#old value #old value
if self.instance.id: #update instance if self.instance.id: #update instance
list_of_values = getattr(self.instance, field).all() list_of_values = getattr(self.instance, field).all()
old_human_values = '; '.join([str(element) for element in list_of_values]) old_human_values = '; '.join([str(element) for element in list_of_values])
previous_value = ','.join([str(element.id) for element in list_of_values]) previous_value = ','.join([str(element.id) for element in list_of_values])
else: #new instance else: #new instance
old_human_values = '' old_human_values = ''
previous_value = '' previous_value = ''
...@@ -91,8 +91,8 @@ class AppointmentEditForm(AppointmentForm): ...@@ -91,8 +91,8 @@ class AppointmentEditForm(AppointmentForm):
else: else:
initial_appointment_types = [] initial_appointment_types = []
fields = OrderedDict() fields = OrderedDict()
for i, tuple in enumerate(self.fields.items()): for i, field_tuple in enumerate(self.fields.items()):
key, value = tuple key, value = field_tuple
fields[key] = value fields[key] = value
if i == APPOINTMENT_TYPES_FIELD_POSITION: if i == APPOINTMENT_TYPES_FIELD_POSITION:
fields['appointment_types'] = forms.ModelMultipleChoiceField(required=False, fields['appointment_types'] = forms.ModelMultipleChoiceField(required=False,
...@@ -157,8 +157,8 @@ class AppointmentAddForm(AppointmentForm): ...@@ -157,8 +157,8 @@ class AppointmentAddForm(AppointmentForm):
super(AppointmentAddForm, self).__init__(*args, **kwargs) super(AppointmentAddForm, self).__init__(*args, **kwargs)
fields = OrderedDict() fields = OrderedDict()
for i, tuple in enumerate(self.fields.items()): for i, field_tuple in enumerate(self.fields.items()):
key, value = tuple key, value = field_tuple
fields[key] = value fields[key] = value
if i == APPOINTMENT_TYPES_FIELD_POSITION: if i == APPOINTMENT_TYPES_FIELD_POSITION:
fields['appointment_types'] = forms.ModelMultipleChoiceField(required=False, fields['appointment_types'] = forms.ModelMultipleChoiceField(required=False,
......
...@@ -13,12 +13,10 @@ class MailTemplateForm(ModelForm): ...@@ -13,12 +13,10 @@ class MailTemplateForm(ModelForm):
def __init__(self, *args, **kwargs): def __init__(self, *args, **kwargs):
super(MailTemplateForm, self).__init__(*args, **kwargs) super(MailTemplateForm, self).__init__(*args, **kwargs)
instance = getattr(self, 'instance', None)
self.fields['Multilingual'] = forms.BooleanField(label='Multilingual', disabled=True, required=False, self.fields['Multilingual'] = forms.BooleanField(label='Multilingual', disabled=True, required=False,
help_text='Only for voucher context. Check this option if the voucher template is multilingual.', help_text='Only for voucher context. Check this option if the voucher template is multilingual.',
widget=forms.CheckboxInput(attrs={'class': 'hidden_form_field', 'id': 'multilingual_checkbox'})) widget=forms.CheckboxInput(attrs={'class': 'hidden_form_field', 'id': 'multilingual_checkbox'}))
def clean(self): def clean(self):
cleaned_data = super(MailTemplateForm, self).clean() cleaned_data = super(MailTemplateForm, self).clean()
return cleaned_data return cleaned_data
\ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment