VISIT_IMPORT_RUN_AT changed into configuration option

smash/web/importer/importer_cron_job.py

@@ -6,12 +6,11 @@ import os.path
 import traceback
 
 import timeout_decorator
-from django.conf import settings
 from django_cron import CronJobBase, Schedule
 
 from web.models import ConfigurationItem
 from web.models.constants import CRON_JOB_TIMEOUT, DEFAULT_FROM_EMAIL, DAILY_SUBJECT_IMPORT_FILE, \
-    DAILY_VISIT_IMPORT_FILE, SUBJECT_IMPORT_RUN_AT
+    DAILY_VISIT_IMPORT_FILE, SUBJECT_IMPORT_RUN_AT, VISIT_IMPORT_RUN_AT
 from web.smash_email import EmailSender
 from .csv_tns_subject_import_reader import TnsCsvSubjectImportReader
 from .csv_tns_visit_import_reader import TnsCsvVisitImportReader
@@ -68,7 +67,10 @@ class SubjectImporterCronJob(CronJobBase):
 
 
 class VisitImporterCronJob(CronJobBase):
-    RUN_AT_TIMES = getattr(settings, "VISIT_IMPORT_RUN_AT", ['23:55'])
+    item = ConfigurationItem.objects.filter(type=VISIT_IMPORT_RUN_AT).first()
+    RUN_AT_TIMES = []
+    if item is not None:
+        RUN_AT_TIMES = item.value.split(';')
     schedule = Schedule(run_at_times=RUN_AT_TIMES)
     code = 'web.import_visits_daily_job'  # a unique code
 

smash/web/migrations/0176_configurationitem_local_setting_clean.py

@@ -3,7 +3,8 @@ from django.conf import settings
 from django.db import migrations
 
 from web.models.constants import DEFAULT_FROM_EMAIL, DAILY_SUBJECT_IMPORT_FILE, DAILY_SUBJECT_EXPORT_FILE, \
-    DAILY_VISIT_IMPORT_FILE, DAILY_VISIT_EXPORT_FILE, SUBJECT_IMPORT_RUN_AT, SUBJECT_EXPORT_RUN_AT, VISIT_EXPORT_RUN_AT
+    DAILY_VISIT_IMPORT_FILE, DAILY_VISIT_EXPORT_FILE, SUBJECT_IMPORT_RUN_AT, SUBJECT_EXPORT_RUN_AT, VISIT_EXPORT_RUN_AT, \
+    VISIT_IMPORT_RUN_AT
 
 
 def create_item(apps, item_type, value, name):
@@ -47,6 +48,9 @@ def configuration_items(apps, schema_editor):
     create_item(apps, VISIT_EXPORT_RUN_AT, ';'.join(export_run_at_times),
                 "At what times should the visit exporter run")
 
+    visit_import_run_at_times = getattr(settings, "VISIT_IMPORT_RUN_AT", ['23:55'])
+    create_item(apps, VISIT_IMPORT_RUN_AT, ';'.join(export_run_at_times),
+                "At what times should the visit importer run")
 
 
 class Migration(migrations.Migration):

smash/web/models/constants.py

@@ -64,6 +64,7 @@ DAILY_VISIT_EXPORT_FILE = "DAILY_VISIT_EXPORT_FILE"
 SUBJECT_IMPORT_RUN_AT = "SUBJECT_IMPORT_RUN_AT"
 SUBJECT_EXPORT_RUN_AT = "SUBJECT_EXPORT_RUN_AT"
 VISIT_EXPORT_RUN_AT = "VISIT_EXPORT_RUN_AT"
+VISIT_IMPORT_RUN_AT = "VISIT_IMPORT_RUN_AT"
 
 RED_CAP_LANGUAGE_4_FIELD_TYPE = 'RED_CAP_LANGUAGE_4_FIELD_TYPE'
 RED_CAP_LANGUAGE_3_FIELD_TYPE = 'RED_CAP_LANGUAGE_3_FIELD_TYPE'